Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding locations to unsupported fields #75

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

ns-iknox
Copy link
Contributor

Description of change

Location data types are unsupported for the bulk API. This PR adds those fields to the unsupported fields list.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    -- Create a custom geolocation field in Salesforce
    -- Create connection selecting all fields
    -- Verify extraction completes without failure

Risks

Rollback steps

  • revert this branch

@cmerrick
Copy link

Hi @ns-iknox, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @ns-iknox!

Thank you for signing the Singer Contribution License Agreement.

Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The message could be parameterized, but with just 2 fields, I don't think it's important.

@dmosorast dmosorast merged commit d130f0f into singer-io:master Mar 30, 2020
@dmosorast dmosorast mentioned this pull request Mar 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants